Push identical image to all Docker registries#445
Merged
bestbeforetoday merged 1 commit intohyperledger:mainfrom Dec 4, 2024
Merged
Push identical image to all Docker registries#445bestbeforetoday merged 1 commit intohyperledger:mainfrom
bestbeforetoday merged 1 commit intohyperledger:mainfrom
Conversation
bestbeforetoday
force-pushed
the
docker-publish
branch
from
4aa884a to
1fa31d5
Compare
bestbeforetoday
changed the title
denyeart
reviewed
Dec 4, 2024
Contributor
denyeart
left a comment
denyeart
left a comment
There was a problem hiding this comment.
Good idea on using the same hash on both images!
I guess we should do this for all repositories?
The current GitHub Actions workflow builds and pushes separate Docker images for each registry. This results in the images published to each registry having a different hash, despite having the same version tag. This change modifies the Docker publishing job in the release workflow so that a single step builds and publishes the same Docker image to all Docker registries. For reproducability, the timestamp of the image is also set to the last commit timestamp. Signed-off-by: Mark S. Lewis <Mark.S.Lewis@outlook.com>
bestbeforetoday
force-pushed
the
docker-publish
branch
from
1fa31d5 to
6ac3c58
Compare
denyeart
approved these changes
Dec 4, 2024
Contributor
denyeart
left a comment
denyeart
left a comment
There was a problem hiding this comment.
Thanks for the update, it makes it much easier to understand upon a quick scan.
I assume we should make a similar update in all the repositories that push to both?
Member
Author
I have made a similar change for review in hyperledger/fabric-chaincode-java#368. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The current GitHub Actions workflow builds and pushes separate Docker images for each registry. This results in the images published to each registry having a different hash, despite having the same version tag.
This change modifies the Docker publishing job in the release workflow so that a single step builds and publishes the same Docker image to all Docker registries. For reproducability, the timestamp of the image is also set to the last commit timestamp.